Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap_attr: Use byte values instead of str #41248

Merged
merged 1 commit into from
Jun 8, 2018
Merged

ldap_attr: Use byte values instead of str #41248

merged 1 commit into from
Jun 8, 2018

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 7, 2018

SUMMARY

The LDAP values may be of any kind (pictures, bytes, etc.) thus, ldap module enforce a "bytes" type.
We should pass properly encoded values instead of str

Fixes: #39569

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/net_tools/ldap/ldap_attr.py

ANSIBLE VERSION
2.7-devel

@Akasurde
ldap_attr: Use byte values instead of str
a9c8e25 
The LDAP values may be of any kind (pictures, bytes, etc.) thus, ldap module enforce a "bytes" type.
We should pass properly encoded values instead of str

Fixes: ansible#39569

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Jun 7, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 7, 2018

cc @jtyr
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. labels Jun 7, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 7, 2018
@jtyr
Copy link
Contributor

jtyr commented Jun 7, 2018

Thanks for this PR, @Akasurde.

@ansibot please shipit.

@Akasurde Akasurde merged commit e3a073f into ansible:devel Jun 8, 2018
@Akasurde Akasurde deleted the i39569 branch June 8, 2018 02:04
@Akasurde
Copy link
Member Author

Akasurde commented Jun 8, 2018

@jtyr Thanks for the review.

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@Akasurde
ldap_attr: Use byte values instead of str (ansible#41248)
b5b34cf 
The LDAP values may be of any kind (pictures, bytes, etc.) thus, ldap module enforce a "bytes" type.
We should pass properly encoded values instead of str

Fixes: ansible#39569

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Saloshp Saloshp mentioned this pull request Sep 10, 2018
Closed
@gustavomcarmo gustavomcarmo mentioned this pull request Sep 20, 2018
Merged
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtyr jtyr jtyr approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ldap_attr - Tuple_to_LDAPMod(): expected a byte string in the list
3 participants
@Akasurde @ansibot @jtyr