Update zabbix_screen.py limit screen columns

[tacid]

Add option graphs_in_row that allows to limit the count of columns on zabbix screen. When graphs_in_row columns is filled, begins to draw next row. If there is many hosts with many graphs each, draws all graphs for one host in an column each below each other

SUMMARY

This patch adds functionality to draws graphs in many rows with max count of graphs_in_row
Before, there was strange behavior all graphs draws in one row, when where is more then 5 hosts in
group -- you got very long row in zabbix screen, one should scroll it vertically

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

module monitoring zabbix zabbix_screen.py

ANSIBLE VERSION

ansible 2.5.4
  config file = /home/srvadm/ansible.cfg
  configured module search path = [u'/home/srvadm/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]

[ansibot]

cc @D3DeFi @cove @eikef @harrisongu
click here for bot help

[ansibot]

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:265:23: E201 whitespace after '('
lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:265:55: E202 whitespace before ')'
lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:298:110: E201 whitespace after '('
lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:298:129: E202 whitespace before ')'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_screen.py:0:0: E305 DOCUMENTATION.options.screens.description.5: expected str @ data['options']['screens']['description'][5]. Got {'Option graphs_in_row will limit columns of screen and make multiple rows (default': '3)'}

click here for bot help

[tacid]

fixed all CI errors

[eikef]

I like it, and LGTM. Thank you!

shipit

[D3DeFi]

Don't have a chance to test your changes, but they look good.
shipit

[tacid]

Maybe we should bump metadata_version in ANSIBLE_MATADATA?
Should I open ne PR?

[D3DeFi]

Imo that is not tied to module itself and shouldn't be changed:
"metadata_version is the version of the ANSIBLE_METADATA schema, not the version of the module.

For more information see this documentation page

[tacid]

Oh! thank you for explaining