Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved support for parameter testing and checks for org_id #41517

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Improved support for parameter testing and checks for org_id #41517

merged 1 commit into from
Jun 20, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 13, 2018

SUMMARY

Fixes bug #41300

org_id is a parameter which can be passed to a module. While it's less intuitive and clean for a playbook, it's also faster since less calls need to be performed. org_id was used in this module but there were no integration tests or checks for no organization being referenced. Checks are now performed for either org_id or org_name and there are integration tests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_snmp

ANSIBLE VERSION
ansible 2.7.0.dev0 (meraki/snmp-orgnetid 7d3f1013d8) last updated 2018/06/13 18:02:13 (GMT -500)
  config file = None
  configured module search path = ['/Users/kbreit/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/kbreit/Documents/Programming/ansible/lib/ansible
  executable location = /Users/kbreit/Documents/Programming/ansible/bin/ansible
  python version = 3.5.4 (default, Feb 25 2018, 14:56:02) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Jun 13, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jun 13, 2018
@kbreit
Copy link
Contributor Author

kbreit commented Jun 14, 2018

shipit

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jun 14, 2018
dagwieers
dagwieers approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers merged commit cccaf95 into ansible:devel Jun 20, 2018
kbreit added a commit to kbreit/ansible that referenced this pull request Jun 20, 2018
@kbreit
Improved support for parameter testing and checks for org_id (ansible…
bf51ebc 
…#41517)

(cherry picked from commit cccaf95)
@kbreit kbreit mentioned this pull request Jun 20, 2018
Merged
mattclay pushed a commit that referenced this pull request Jun 21, 2018
@kbreit @mattclay
Improved support for parameter testing and checks for org_id (#41517)
933ca5a 
(cherry picked from commit cccaf95)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@kbreit
Improved support for parameter testing and checks for org_id (ansible…
9506ea4 
…#41517)
kbreit added a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@kbreit
Improved support for parameter testing and checks for org_id (ansible…
44babfc 
…#41517)

(cherry picked from commit cccaf95)
@kbreit kbreit deleted the meraki/snmp-orgnetid branch September 28, 2018 16:01
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kbreit @ansibot @dagwieers @achinthagunasekara @jborean93