Fix junos_config confirm commit issue #41527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#40626 * Due to issue in ncclient commit() method for Juniper device (ncclient/ncclient#238) add a workaround in junos netconf plugin to generate proper commit-configuration xml and execute it using ncclient generic `rpc()` method.
ansibot
added
affects_2.7
ganeshrn
removed
the
needs_triage
ansibot
added
core_review
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Jun 29, 2018
* Fix junos_config confirm commit issue Fixes ansible#40626 * Due to issue in ncclient commit() method for Juniper device (ncclient/ncclient#238) add a workaround in junos netconf plugin to generate proper commit-configuration xml and execute it using ncclient generic `rpc()` method. * Update junos_config doc (cherry picked from commit 88b966e)
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Jun 29, 2018
Fixes ansible#40626 * Due to issue in ncclient commit() method for Juniper device (ncclient/ncclient#238) add a workaround in junos netconf plugin to generate proper commit-configuration xml and execute it using ncclient generic `rpc()` method. * Update junos_config doc * Update changelog (cherry picked from commit 88b966e)
nitzmahone
pushed a commit
that referenced
this pull request
Jul 3, 2018
Fixes #40626 * Due to issue in ncclient commit() method for Juniper device (ncclient/ncclient#238) add a workaround in junos netconf plugin to generate proper commit-configuration xml and execute it using ncclient generic `rpc()` method. * Update junos_config doc * Update changelog (cherry picked from commit 88b966e)
mattclay
pushed a commit
that referenced
this pull request
Jul 3, 2018
* Fix junos_config confirm commit issue Fixes #40626 * Due to issue in ncclient commit() method for Juniper device (ncclient/ncclient#238) add a workaround in junos netconf plugin to generate proper commit-configuration xml and execute it using ncclient generic `rpc()` method. * Update junos_config doc (cherry picked from commit 88b966e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #40626
device (confirm-commit and check fails on junos devices ncclient/ncclient#238)
add a workaround in junos netconf plugin to generate proper
commit-configuration xml and execute it using ncclient
generic
rpc()method.ISSUE TYPE
COMPONENT NAME
junos_config
ANSIBLE VERSION
ADDITIONAL INFORMATION