Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if folder already exists before creation #41588

Merged
merged 2 commits into from
Jul 30, 2018
Merged

check if folder already exists before creation #41588

merged 2 commits into from
Jul 30, 2018

Conversation

orryun
Copy link
Contributor

@orryun orryun commented Jun 15, 2018 •
edited

SUMMARY

Ansible will check if folder exists before creation

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vcenter_folder

ANSIBLE VERSION

2.7

@ansibot
Copy link
Contributor

ansibot commented Jun 15, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jun 15, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 15, 2018
@Akasurde
Copy link
Member

@orryun Thanks for the PR. Could you please add integration test for this change here - https://github.com/ansible/ansible/tree/devel/test/integration/targets/vcenter_folder/tasks ?

@ansibot ansibot added test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 15, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 15, 2018
@orryun
Copy link
Contributor Author

orryun commented Jun 15, 2018

@Akasurde I added a simple test, any other thoughts?

@Akasurde
Copy link
Member

cc @dericcrago @pdellaert Could you please review this ?

@orryun orryun closed this Jun 25, 2018
@orryun orryun reopened this Jun 25, 2018
@orryun
Copy link
Contributor Author

orryun commented Jun 29, 2018

When PRs usually get merged here?

@Akasurde
Copy link
Member

@orryun We need to 2 approvals for PR to get merge. You have one and will have to wait for one more. I pinged 2 people who can give you one. Once that is done we can merge it.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 7, 2018
@Akasurde
Copy link
Member

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this Jul 27, 2018
@Akasurde Akasurde reopened this Jul 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2018
@Akasurde Akasurde merged commit 1e4831e into ansible:devel Jul 30, 2018
@Akasurde
Copy link
Member

@orryun Thanks for the contribution.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orryun @ansibot @Akasurde @mkrizek