Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in group_by module #41627

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fix typo in group_by module #41627

merged 1 commit into from
Jun 18, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Fixes: #31600

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/inventory/group_by.py

ANSIBLE VERSION
2.7-devel

@Akasurde
Fix typo in group_by module
3bee66a 
Fixes: ansible#31600

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Jun 17, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 17, 2018

cc @jhoekx
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. inventory Inventory category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 17, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 18, 2018
@Akasurde Akasurde requested a review from mkrizek June 18, 2018 09:21
@Akasurde Akasurde merged commit fb7fdc5 into ansible:devel Jun 18, 2018
@Akasurde Akasurde deleted the group_by_typo branch June 18, 2018 10:03
@Akasurde
Copy link
Member Author

@mkrizek Thanks for the review.

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@Akasurde
Fix typo in group_by module (ansible#41627)
85a9c3f 
Fixes: ansible#31600

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. inventory Inventory category module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group_by example error?
3 participants
@Akasurde @ansibot @mkrizek