Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vyos_vlan aggregate issue & added tests #41638

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Fix vyos_vlan aggregate issue & added tests #41638

merged 2 commits into from
Jun 19, 2018

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Jun 18, 2018 •
edited

SUMMARY
  • Fixes issue: Aggregates not working on vyos_vlan #41528
  • With this fix, VLANs can now be configured using aggregate
  • Checks for and throws appropriate error message when vlan_id is not provided in an aggregate item
  • Added integration tests
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vyos_vlan.py

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Jun 18, 2018

cc @Qalthos @samdoran @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jun 18, 2018
@NilashishC NilashishC changed the title Fix vyos_vlan aggregate issue & Added tests Fix vyos_vlan aggregate issue & added tests Jun 19, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 19, 2018
@NilashishC NilashishC merged commit 837c216 into ansible:devel Jun 19, 2018
@samdoran samdoran mentioned this pull request Jun 21, 2018
Closed
mattclay pushed a commit that referenced this pull request Jun 22, 2018
@NilashishC @mattclay
Fix vyos_vlan aggregate issue & added tests (#41638)
7cb2486 
* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue

(cherry picked from commit 837c216)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@NilashishC
Fix vyos_vlan aggregate issue & added tests (ansible#41638)
e0ec616 
* Fix vyos_vlan aggregate issue & Added tests

* Fix ansible#2 for vyos_vlan aggregate issue
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@NilashishC @kbreit
Fix vyos_vlan aggregate issue & added tests (ansible#41638)
6533b8c 
* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue

(cherry picked from commit 837c216)
nitzmahone pushed a commit that referenced this pull request Jul 3, 2018
@NilashishC @nitzmahone
Fix vyos_vlan aggregate issue & added tests CP into 2.5 (#41638) (#41775
b9904b9 
)

* Fix vyos_vlan aggregate issue & added tests (#41638)

* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue

(cherry picked from commit 837c216)

* Added changelog for vyos_vlan aggregate issue fix
@NilashishC NilashishC deleted the fix_vyos_vlan branch July 26, 2018 11:16
@ansible ansible locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NilashishC @ansibot @Qalthos @achinthagunasekara @ganeshrn