Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Pure Storage module to discover facts for FlashBlade #41673

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Add new Pure Storage module to discover facts for FlashBlade #41673

merged 1 commit into from
Aug 28, 2018

Conversation

sdodsley
Copy link
Contributor

SUMMARY

Add new module to discover facts for a Pure Storage FlashBlade

Facts that can be discovered are:

  • all
  • minimum
  • config
  • performance
  • capacity
  • network
  • subnets
  • lags
  • filesystems
  • snapshots
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

module/storage/purestorage/purefb_facts

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. performance storage support:community This issue/PR relates to code supported by the Ansible community. labels Jun 18, 2018
@sdodsley sdodsley force-pushed the purefb_facts branch 2 times, most recently from f84d2b6 to af63fb5 Compare June 18, 2018 23:38
@ansibot
Copy link
Contributor

ansibot commented Jun 18, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefb_facts.py:91:10: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefb_facts.py:91:10: error RETURN: syntax error: expected <block end>, but found ','

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 18, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Jun 19, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 14, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 23, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 3, 2018
@sdodsley sdodsley force-pushed the purefb_facts branch 3 times, most recently from da3dff4 to ad5992d Compare August 10, 2018 21:35
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2018
@sdodsley
Add new Pure Storage module to discover facts for FlashBlade
d9b2fb0 
Facts that can be discovered are:
- all
- minimum
- config
- performance
- capacity
- network
- subnets
- lags
- filesystems
- snapshots
@gundalow gundalow merged commit 9bf12ee into ansible:devel Aug 28, 2018
@gundalow
Copy link
Contributor

Thanks, merged into devel for release in Ansible 2.7

@sdodsley sdodsley deleted the purefb_facts branch September 2, 2018 16:30
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@wobbly2732 wobbly2732 wobbly2732 approved these changes

@sbelenitsky sbelenitsky sbelenitsky approved these changes

@genegr genegr genegr approved these changes

@aReT1903 aReT1903 aReT1903 approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. performance storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sdodsley @ansibot @gundalow @wobbly2732 @sbelenitsky @genegr @aReT1903 @ryansb