Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_config_template - Remove extraneous json.loads() which was moved to the utility. #41731

Merged
merged 1 commit into from
Jun 22, 2018
Merged

meraki_config_template - Remove extraneous json.loads() which was moved to the utility. #41731

merged 1 commit into from
Jun 22, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 20, 2018

SUMMARY

The meraki_config_template module has a line which uses json.loads() for a HTTP call. This functionality was moved to the utility so this is causing an error. Removing the loads() call fixes the problem.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_config_template

ANSIBLE VERSION
ansible 2.7.0.dev0 (meraki/config_template_loads_fix 5f7b66d202) last updated 2018/06/20 09:00:18 (GMT -500)
  config file = None
  configured module search path = ['/Users/kbreit/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/kbreit/Documents/Programming/ansible/lib/ansible
  executable location = /Users/kbreit/Documents/Programming/ansible/bin/ansible
  python version = 3.5.4 (default, Feb 25 2018, 14:56:02) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Jun 20, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 20, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2018
@dagwieers
Copy link
Contributor

LGTM

@dagwieers dagwieers merged commit 4d5d0b6 into ansible:devel Jun 22, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@kbreit
Remove extarneous json.loads() which was moved to the utility. (ansib…
e71c78d 
…le#41731)
@kbreit kbreit deleted the meraki/config_template_loads_fix branch July 6, 2018 14:36
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @ansibot @dagwieers @jborean93