Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_updates fix when win_updates is run with async #41756

Merged
merged 1 commit into from
Jun 20, 2018
Merged

win_updates fix when win_updates is run with async #41756

merged 1 commit into from
Jun 20, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

When running win_updates with async it currently fails due to the check after the first run to see if updates has been returned. In the case of async that will never happen so we ignore that particular check if async is greater than 0.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_updates

ANSIBLE VERSION
devel

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 20, 2018
@nitzmahone nitzmahone merged commit 11bd3fd into ansible:devel Jun 20, 2018
@jborean93 jborean93 deleted the win_updates-async branch June 20, 2018 21:54
jborean93 added a commit to jborean93/ansible that referenced this pull request Jun 20, 2018
@jborean93
win_updates fix when win_updates is run with async (ansible#41756)
44c75d6 
(cherry picked from commit 11bd3fd)
jborean93 added a commit to jborean93/ansible that referenced this pull request Jun 20, 2018
@jborean93
win_updates fix when win_updates is run with async (ansible#41756)
e2eb22a 
(cherry picked from commit 11bd3fd)
This was referenced Jun 20, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.5 #41763
stable-2.6 #41764

nitzmahone pushed a commit that referenced this pull request Jun 20, 2018
@jborean93 @nitzmahone
win_updates fix when win_updates is run with async (#41756) (#41763)
2f0cfa8 
(cherry picked from commit 11bd3fd)
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2018
mattclay pushed a commit that referenced this pull request Jun 21, 2018
@jborean93 @mattclay
win_updates fix when win_updates is run with async (#41756)
9ce55f7 
(cherry picked from commit 11bd3fd)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@jborean93
win_updates fix when win_updates is run with async (ansible#41756)
4e6e382
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@jborean93 @kbreit
win_updates fix when win_updates is run with async (ansible#41756)
109edc3 
(cherry picked from commit 11bd3fd)
@ansible ansible locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @nitzmahone @samdoran @ansibot