Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runas + async - get working on older hosts #41772

Merged
merged 5 commits into from
Jun 26, 2018
Merged

runas + async - get working on older hosts #41772

merged 5 commits into from
Jun 26, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Changed the async process to always work even in connections that don't allow breakaway from the parent job. This means we can get tasks that use become and async to work on Server 2008 and 2008 R2 whereas before they could not be used together.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

powershell

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2018

cc @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Jun 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2018

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/plugins/shell/powershell.py:1142:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1186:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1188:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1192:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1194:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1197:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1199:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1205:1: W293 blank line contains whitespace
lib/ansible/plugins/shell/powershell.py:1207:1: W293 blank line contains whitespace

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 21, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 22, 2018
@jborean93 jborean93 merged commit 2af3641 into ansible:devel Jun 26, 2018
@jborean93 jborean93 deleted the win-async-become branch June 26, 2018 04:40
@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @ansibot @nitzmahone @samdoran