Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_affinity_lables_facts: Raise error when host/vm not found #41790

Merged
merged 1 commit into from
Jul 3, 2018
Merged

ovirt_affinity_lables_facts: Raise error when host/vm not found #41790

merged 1 commit into from
Jul 3, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

When virtual machine or host is not found for affinity lable, we should raise error so user knows it don't exists and he has typo most probably.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_affinity_label_facts

ANSIBLE VERSION
2.5.2
ADDITIONAL INFORMATION

@machacekondra
Copy link
Contributor Author

Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=1575590

@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 21, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2018
mwperina
mwperina approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@mwperina
Copy link
Contributor

mwperina commented Jul 3, 2018

+label affects_2.6

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 3, 2018
@ansibot ansibot merged commit 0a6ab23 into ansible:devel Jul 3, 2018
@machacekondra machacekondra mentioned this pull request Jul 12, 2018
Merged
@machacekondra machacekondra deleted the fix_lables_facts branch August 15, 2018 10:42
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machacekondra @ansibot @mwperina @dagwieers @samdoran