Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf: Call dnf.Base.close() before exit to cleanup. #41810

Merged
merged 1 commit into from
Jul 18, 2018
Merged

dnf: Call dnf.Base.close() before exit to cleanup. #41810

merged 1 commit into from
Jul 18, 2018

Conversation

opoplawski
Copy link
Contributor

SUMMARY

On exit of dnf module, the dnf object still holds many file open.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

ANSIBLE VERSION
ansible 2.5.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Apr 13 2018, 04:32:41) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

I'm running ansible with mitogen. Ths was failing on Fedora with processes running out of file descriptors. This is because mitogen runs each tasks in the same process and dnf was not closing file descriptors. Eventually it would run out. See mitogen-hq/mitogen#280 for more information.

@opoplawski opoplawski mentioned this pull request Jun 21, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2018

cc @DJMuggs @berenddeschouwer @ignatenkobrain
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 21, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 29, 2018
@maxamillion
Copy link
Contributor

shipit

@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 18, 2018
@ansibot ansibot merged commit 32436ea into ansible:devel Jul 18, 2018
maxamillion added a commit to maxamillion/ansible that referenced this pull request Jul 20, 2018
@maxamillion
Revert "dnf: Call dnf.Base.close() before exit to cleanup. (ansible#4…
cdca962 
…1810)"

This reverts commit 32436ea.
@abadger
Copy link
Contributor

abadger commented Jul 31, 2018

This was reverted in #43110 due to breaking the results returned from the module.

saichint pushed a commit to saichint/ansible that referenced this pull request Jul 31, 2018
@maxamillion @abadger
Revert "dnf: Call dnf.Base.close() before exit to cleanup. (ansible#4…
09eac6b 
…1810)"

This reverts commit 32436ea.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@opoplawski @ansibot @maxamillion @abadger @samdoran