Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backup feature to user module #41854

Merged
merged 7 commits into from
Aug 15, 2018
Merged

Add backup feature to user module #41854

merged 7 commits into from
Aug 15, 2018

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jun 22, 2018 •
edited

SUMMARY

Add feature to backup shadow file only on platforms where the module modifies the shadow file directly, which are currently SunOS variants.

Fixes #40696

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

user.py

ANSIBLE VERSION
2.7

@ansibot
Copy link
Contributor

ansibot commented Jun 22, 2018

cc @sfromm
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 22, 2018
bcoca
bcoca reviewed Jun 22, 2018
View reviewed changes
lib/ansible/modules/system/user.py Outdated
@@ -194,6 +194,14 @@
type: bool
default: 'no'
version_added: "2.4"
backup:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would not even make this an option, specially since it behaves differntly than other 'backup' options, we should just 'do this'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll just add a note then and remove the option.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 22, 2018
@ansibot ansibot added test This PR relates to tests. and removed owner_pr This PR is made by the module's maintainer. labels Jun 22, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 22, 2018

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/user-module-backup-shadow.yaml:0:0: invalid section: minor_features

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 22, 2018
@samdoran
Remove backup option, make it automatic
e6f7934 
Remove the option to enable/disable backups and make it automatic. Add note to docs describing this behavior.

Change tests to account for new module behavior.

Change section name in changelog fragment since minor_features is not a valid section.
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 25, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Jul 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 6, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 14, 2018
@samdoran
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 15, 2018
@ansibot ansibot merged commit 00e7c02 into ansible:devel Aug 15, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user module should backup shadow to shadow-
3 participants
@samdoran @ansibot @bcoca