Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update synchronize.py, mention variable ansible_rsync_path needed for different local rsync binary #41870

Merged
merged 2 commits into from Sep 25, 2018
Merged

Update synchronize.py, mention variable ansible_rsync_path needed for different local rsync binary #41870

merged 2 commits into from Sep 25, 2018

Conversation

tomww
Copy link
Contributor

@tomww tomww commented Jun 23, 2018

If you want a different rsync binary on the local side, you need to set task variable ansible_rsync_path.
See examples.

Variable ansible_rsync_path looks to not be documented anywhere. If documented, needs to be said that is does not belong to synchronise options, instead belongs to tasks. (Sorry, I have no better wording)

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@tomww
Update synchronize.py
ae2400b 
If you want a different rsync binary on the local side, you need to set task variable ansible_rsync_path.
See examples.

Variable ansible_rsync_path looks to not be documented anywhere. If documented, needs to be said that is does not belong to synchronise options, instead belongs to tasks. (Sorry, I have no better wording)


+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2018

cc @tima
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2018

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/files/synchronize.py:116:161: E501 line too long (214 > 160 characters)
lib/ansible/modules/files/synchronize.py:304:1: W293 blank line contains whitespace
lib/ansible/modules/files/synchronize.py:305:67: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 23, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Jun 25, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 25, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 3, 2018
@gundalow
Copy link
Contributor

Thank you for this PR, I've push a minor change to address the CI issues in daaff7b

If that passes I'll merge

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 25, 2018
@gundalow gundalow merged commit c44de10 into ansible:devel Sep 25, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Sep 25, 2018
@tomww @gundalow
Update synchronize.py, mention variable ansible_rsync_path needed for…
e094c0b 
… different local rsync binary (ansible#41870)

* Update synchronize.py

If you want a different rsync binary on the local side, you need to set task variable ansible_rsync_path.
See examples.

Variable ansible_rsync_path looks to not be documented anywhere. If documented, needs to be said that is does not belong to synchronise options, instead belongs to tasks. (Sorry, I have no better wording)
(cherry picked from commit c44de10)
@gundalow gundalow mentioned this pull request Sep 25, 2018
Merged
acozine pushed a commit that referenced this pull request Sep 25, 2018
@gundalow @acozine
Update synchronize.py, mention variable ansible_rsync_path needed for…
ab1b602 
… different local rsync binary (#41870) (#46110)

* Update synchronize.py

If you want a different rsync binary on the local side, you need to set task variable ansible_rsync_path.
See examples.

Variable ansible_rsync_path looks to not be documented anywhere. If documented, needs to be said that is does not belong to synchronise options, instead belongs to tasks. (Sorry, I have no better wording)
(cherry picked from commit c44de10)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomww @ansibot @gundalow @dagwieers