Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_iis_webapppool: do not output some cmdlet outputs #41884

Merged
merged 1 commit into from
Jun 26, 2018
Merged

win_iis_webapppool: do not output some cmdlet outputs #41884

merged 1 commit into from
Jun 26, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Some cmdlets used in win_iis_webapppool generate output and returns that back with the JSON. This can, in some situations, break the Ansible controller reader causing a failure when one didn't actually occur.

Fixes #40874

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_iis_webapppool

ANSIBLE VERSION
devel

@jborean93 jborean93 mentioned this pull request Jun 24, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 24, 2018

cc @dagwieers @henrikwallstrom @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jun 24, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 25, 2018
@jborean93 jborean93 merged commit abfcc35 into ansible:devel Jun 26, 2018
@jborean93 jborean93 deleted the win_iis_webapppool-output branch June 26, 2018 01:32
jborean93 added a commit to jborean93/ansible that referenced this pull request Jun 26, 2018
@jborean93
win_iis_webapppool: do not output some cmdlet outputs (ansible#41884)
63f9a60 
(cherry picked from commit abfcc35)
jborean93 added a commit to jborean93/ansible that referenced this pull request Jun 26, 2018
@jborean93
win_iis_webapppool: do not output some cmdlet outputs (ansible#41884)
74afb40 
(cherry picked from commit abfcc35)
This was referenced Jun 26, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.5 #41942
stable-2.6 #41943

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@jborean93
win_iis_webapppool: do not output some cmdlet outputs (ansible#41884)
4e415df
mattclay pushed a commit that referenced this pull request Jun 26, 2018
@jborean93 @mattclay
win_iis_webapppool: do not output some cmdlet outputs (#41884)
cfb4a82 
(cherry picked from commit abfcc35)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@jborean93 @kbreit
win_iis_webapppool: do not output some cmdlet outputs (ansible#41884)
913e0df 
(cherry picked from commit abfcc35)
nitzmahone pushed a commit that referenced this pull request Jul 3, 2018
@jborean93 @nitzmahone
win_iis_webapppool: do not output some cmdlet outputs (#41884) (#41942)
c2d905f 
(cherry picked from commit abfcc35)
@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IIS apppool creation is succesfull, but task fails with "module failure"
3 participants
@jborean93 @ansibot @sivel