Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more detail error on bad http code return for modules vmware vmware_guest_file_operation.py #41897

Merged
merged 3 commits into from
Sep 10, 2018
Merged

more detail error on bad http code return for modules vmware vmware_guest_file_operation.py #41897

merged 3 commits into from
Sep 10, 2018

Conversation

stravassac
Copy link
Contributor

SUMMARY

more detail error on bad http code return for modules vmware vmware_guest_file_operation.py
Fixes #41721

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest_file_operation.py

ANSIBLE VERSION
ansible 2.6.0
  config file = None
  configured module search path = [u'/home/stravassac/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/stravassac/virtualenvs/ansible_dev/local/lib/python2.7/site-packages/ansible
  executable location = /home/stravassac/virtualenvs/ansible_dev/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 25, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jun 25, 2018
@stravassac
Copy link
Contributor Author

forgot some informations

@stravassac stravassac closed this Jun 25, 2018
@stravassac stravassac reopened this Jun 25, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. small_patch labels Jun 25, 2018
@stravassac stravassac closed this Jun 25, 2018
@stravassac stravassac reopened this Jun 25, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 25, 2018
Akasurde
Akasurde reviewed Jun 25, 2018
View reviewed changes
lib/ansible/modules/cloud/vmware/vmware_guest_file_operation.py Outdated
@@ -21,7 +21,7 @@
- Module to copy a file to a VM, fetch a file from a VM and create or delete a directory in the guest OS.
version_added: "2.5"
author:
- Stéphane Travassac (@stravassac)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this as GitHub handle as this is used by Ansibot.

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

@stravassac This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Jun 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

@stravassac this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 26, 2018
stravassac added 3 commits June 26, 2018 09:50
Issues:#41721
8356550 
more detail error on bad http code return for modules vmware vmware_guest_file_operation.py
provide full information on InitiateFileTransferToGuest http error
8968714
Keep @stravassac for Ansibot
1bdb853
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 26, 2018
@stravassac
Copy link
Contributor Author

@Akasurde it's all right for you

@ansibot ansibot added owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 10, 2018
@stravassac
Copy link
Contributor Author

@Akasurde it's all right for you ?

@Akasurde
Copy link
Member

Akasurde commented Sep 7, 2018

rebuild_merge

@Akasurde
Copy link
Member

Akasurde commented Sep 9, 2018

Closing and re-opening for CI trigger.

@Akasurde Akasurde closed this Sep 9, 2018
@Akasurde Akasurde reopened this Sep 9, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 9, 2018
@Akasurde Akasurde merged commit 0f7ef14 into ansible:devel Sep 10, 2018
@Akasurde
Copy link
Member

@stravassac Thanks for the contribution.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use vmware_guest_file_operation module to copy localhost file to VM without network, the copy doesn't work.
3 participants
@stravassac @ansibot @Akasurde