Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_network - Fixes idempotency check for partial configurations #41941

Merged
merged 1 commit into from
Jun 26, 2018
Merged

meraki_network - Fixes idempotency check for partial configurations #41941

merged 1 commit into from
Jun 26, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 26, 2018

SUMMARY
  • Previous PR would overwrite new and existing values improperly
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_network

ANSIBLE VERSION
ansible 2.7.0.dev0 (meraki/net-overwrite-fix baeafbefee) last updated 2018/06/25 20:18:45 (GMT -500)
  config file = None
  configured module search path = ['/Users/kbreit/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/kbreit/Documents/Programming/ansible/lib/ansible
  executable location = /Users/kbreit/Documents/Programming/ansible/bin/ansible
  python version = 3.5.4 (default, Feb 25 2018, 14:56:02) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@kbreit
Fixes idempotency check for partial configurations
baeafbe 
- Previous PR would overwrite new and existing values improperly
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jun 26, 2018
@dagwieers dagwieers merged commit 7ab3f75 into ansible:devel Jun 26, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2018
@kbreit kbreit deleted the meraki/net-overwrite-fix branch July 3, 2018 14:10
kbreit added a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@kbreit
Fixes idempotency check for partial configurations (ansible#41941)
035bb1a 
- Previous PR would overwrite new and existing values improperly

(cherry picked from commit 7ab3f75)
mattclay pushed a commit that referenced this pull request Jul 3, 2018
@kbreit @mattclay
Fixes idempotency check for partial configurations (#41941)
d2b447e 
- Previous PR would overwrite new and existing values improperly

(cherry picked from commit 7ab3f75)
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @ansibot @dagwieers @webknjaz