Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken dependencies in 2.6 #41946

Merged
merged 7 commits into from
Jun 26, 2018
Merged

Broken dependencies in 2.6 #41946

merged 7 commits into from
Jun 26, 2018

Conversation

zikalino
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jun 26, 2018
@ansibot ansibot added azure cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed small_patch labels Jun 26, 2018
@mattclay
Copy link
Member

@zikalino Is this a backport of an existing change in the devel branch?

@zikalino
Copy link
Contributor Author

@mattclay partial. i just want to add minimal fixes needed to resolve dependencies issues that broke 2.6 (and also 2.5). should i do it in different way?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2018
@mattclay
Copy link
Member

cc @nitzmahone

@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:148:1: A102 Remove since "lib/ansible/modules/cloud/azure/azure_rm_containerinstance.py" passes "E324" test

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 26, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:148:1: A102 Remove since "lib/ansible/modules/cloud/azure/azure_rm_containerinstance.py" passes "E324" test

click here for bot help

@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jun 26, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 26, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 26, 2018
@zikalino zikalino changed the title fixed requirements Broken dependencies in 2.6 Jun 26, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 26, 2018
@mattclay mattclay merged commit 701d615 into ansible:stable-2.6 Jun 26, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@kbreit
Fix broken Azure dependencies in 2.6 (ansible#41946)
cb9cb16 
* fixed requirements
* module fix
* updated test accordingly
* mysql & postgresl fixes
* upgraded databases
* removed test from ignore.txt
* updated mysql & postgresql tests
@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

@jborean93 jborean93 Awaiting requested review from jborean93

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 azure backport This PR does not target the devel branch. cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zikalino @ansibot @mattclay