Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed boolean value for zone_redundant in azure_rm_sqldatabase.py #41974

Merged
merged 1 commit into from
Sep 3, 2018
Merged

fixed boolean value for zone_redundant in azure_rm_sqldatabase.py #41974

merged 1 commit into from
Sep 3, 2018

Conversation

vpopescu
Copy link
Contributor

SUMMARY

Per https://docs.microsoft.com/en-us/azure/templates/microsoft.sql/servers/databases, the zone_redundant field is a boolean, but it's passed in as a string, causing a deserialization error while trying to create a sql database in azure.

Fixes #41742

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_sqldatabase.py

ANSIBLE VERSION
ansible 2.5.3
  config file = None
  configured module search path = ['/home/val/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.5/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.5.2 (default, Nov 23 2017, 16:37:01) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

Please review the change carefully, I'm not sure why maintainer cannot replicate the issue.

@vpopescu vpopescu mentioned this pull request Jun 26, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2018

cc @zikalino
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 26, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Jun 27, 2018
Closed
@jelledebruin66
Copy link

I can confirm that the proposed solution fixes the problem.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 5, 2018
@yungezz
Copy link
Contributor

yungezz commented Jul 16, 2018

@vpopescu thanks for the contribution. could you pls modify one of existing test case to cover this paramter? thanks.

@yuwzho
Copy link
Contributor

yuwzho commented Aug 9, 2018

kindly ping

@Fred-sun
Copy link
Contributor

@vpopescu Thanks for you contribute to open this PR. Could you help update the PR status? ready for review or need new change? Thanks!

@yungezz yungezz requested a review from zikalino August 13, 2018 02:58
@Fred-sun
Copy link
Contributor

@zikalino Please help to review this PR. Thanks!

2 similar comments
@Fred-sun
Copy link
Contributor

@zikalino Please help to review this PR. Thanks!

@Fred-sun
Copy link
Contributor

@zikalino Please help to review this PR. Thanks!

@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript
click here for bot help

@zikalino zikalino merged commit b4c148b into ansible:devel Sep 3, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@zikalino zikalino zikalino approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. python3 small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_rm_sqldatabase has started failing with deserialization error
9 participants
@vpopescu @ansibot @jelledebruin66 @yungezz @yuwzho @Fred-sun @achinthagunasekara @zikalino @ryansb