Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_domain: fix typo in cmdlet call #41993

Merged
merged 1 commit into from
Jun 27, 2018
Merged

win_domain: fix typo in cmdlet call #41993

merged 1 commit into from
Jun 27, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

This normally shouldn't be an issue as PS cmdlet params are not case sensitive but in this case it is causing some issues.

Fixes #41536

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain

ANSIBLE VERSION
devel

@jborean93 jborean93 mentioned this pull request Jun 27, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 27, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jun 27, 2018
@jborean93 jborean93 merged commit 77526a5 into ansible:devel Jun 27, 2018
@jborean93 jborean93 deleted the win_domain_typo branch June 27, 2018 01:29
jborean93 added a commit to jborean93/ansible that referenced this pull request Jun 27, 2018
@jborean93
win_domain: fix typo in cmdlet call (ansible#41993)
6b74f25 
(cherry picked from commit 77526a5)
jborean93 added a commit to jborean93/ansible that referenced this pull request Jun 27, 2018
@jborean93
win_domain: fix typo in cmdlet call (ansible#41993)
bf3f74e 
(cherry picked from commit 77526a5)
This was referenced Jun 27, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.5 #41994
stable-2.6 #41995

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 28, 2018
nitzmahone pushed a commit that referenced this pull request Jul 3, 2018
@jborean93 @nitzmahone
win_domain: fix typo in cmdlet call (#41993) (#41994)
ceb14fc 
(cherry picked from commit 77526a5)
mattclay pushed a commit that referenced this pull request Jul 3, 2018
@jborean93 @mattclay
win_domain: fix typo in cmdlet call (#41993)
e65f7d2 
(cherry picked from commit 77526a5)
@ansible ansible locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in win_domain module
3 participants
@jborean93 @ansibot @mkrizek