Restore BOOLEANS import in basic.py #42008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ansibot
added
affects_2.7
Akasurde
removed
the
needs_triage
|
Maybe add a comment that BOOLENS is there for backwards compatibility. Otherwise +1 to merge. Needs to be backported to stable-2.6 and stable-2.5 |
ansibot
added
shipit
|
Closing and re-opening for CI trigger. |
|
Code looks good. We need to have a changelog entry for this as well. Something like restore module_utils.basic.BOOLEANS variable for backwards compatibility with the module API in older ansible releases. This was mistakenly removed in 2.5.0. |
This import was removed by mistake. This is required for backward compatibility. Fixes: ansible#41988 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
boolean_restore
branch
from
96f9efe
to
d83be40
Compare
|
rebuild_merge |
ansibot
removed
the
needs_revision
Akasurde
added a commit
to Akasurde/ansible
that referenced
this pull request
Jul 3, 2018
This import was removed by mistake. This is required for backward compatibility. Fixes: ansible#41988 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
added a commit
to Akasurde/ansible
that referenced
this pull request
Jul 3, 2018
This import was removed by mistake. This is required for backward compatibility. Fixes: ansible#41988 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
nitzmahone
pushed a commit
that referenced
this pull request
Jul 3, 2018
mattclay
pushed a commit
that referenced
this pull request
Jul 3, 2018
This import was removed by mistake. This is required for backward compatibility. Fixes: #41988 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This import was removed by mistake. This is required for backward
compatibility.
Fixes: #41988
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/basic.py
ANSIBLE VERSION