Fix NameError in pause module #42038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
samdoran
removed
the
needs_triage
|
Good fix. Thanks! This is what I was going for, but evidently failed to get in right. Could you add tests for this? |
|
Sure, I'll work on this later. |
ansibot
removed
the
needs_revision
|
On second thought, I don't think we need tests for this. Just a comment in the code will suffice. |
ansibot
added
the
stale_ci
ansibot
added
needs_ci
samdoran
pushed a commit
to samdoran/ansible
that referenced
this pull request
Jul 11, 2018
* Fix NameError in pause module * Add comment and changelog Co-authored-by: Jerry Chong <jchong@netbase.com> (cherry picked from commit 42f44b2)
samdoran
pushed a commit
to samdoran/ansible
that referenced
this pull request
Jul 11, 2018
* Fix NameError in pause module * Add comment and changelog Co-authored-by: Jerry Chong <jchong@netbase.com> (cherry picked from commit 42f44b2)
mattclay
pushed a commit
that referenced
this pull request
Jul 17, 2018
* Fix NameError in pause module * Add comment and changelog Co-authored-by: Jerry Chong <jchong@netbase.com> (cherry picked from commit 42f44b2)
nitzmahone
pushed a commit
that referenced
this pull request
Jul 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes #42004 by nesting the try-catch for curses.error, which would otherwise be triggered when the curses library is not installed.
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/action/pause.py
ANSIBLE VERSION
ansible 2.5.4
ADDITIONAL INFORMATION
See #42004