Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate foreman and katello modules #42043

Merged
merged 5 commits into from
Sep 19, 2018
Merged

Deprecate foreman and katello modules #42043

merged 5 commits into from
Sep 19, 2018

Conversation

ehelms
Copy link
Contributor

@ehelms ehelms commented Jun 28, 2018 •
edited

SUMMARY

Deprecating the Foreman and Katello modules that were in preview in favor of the newer and re-designed modules that currently live at https://github.com/theforeman/foreman-ansible-modules. Users will find the same functionality and more in that repository.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

foreman
katello

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 28, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Jun 28, 2018
samdoran
samdoran suggested changes Jun 28, 2018
View reviewed changes
lib/ansible/modules/remote_management/foreman/foreman.py Outdated
'supported_by': 'community'}

DOCUMENTATION = '''
---
module: foreman
short_description: Manage Foreman Resources
deprecated:
removed_in: "2.9"
why: "Replaced by re-designed individual modules living at https://github.com/theforeman/foreman-ansible-modules"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an alternative field describing alternate module(s) to use.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 28, 2018
gundalow
gundalow requested changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

  1. An entry to to docs/docsite/rst/porting_guides/porting_guide_2.7.rst
  2. A changelog/fragment

lib/ansible/modules/remote_management/foreman/foreman.py Outdated
'supported_by': 'community'}

DOCUMENTATION = '''
---
module: foreman
short_description: Manage Foreman Resources
deprecated:
removed_in: "2.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation cycle is four, so 2.7+4 = "2.11"

@ehelms ehelms force-pushed the deprecate-katello-foreman branch from 97cd0a7 to acf9a7a Compare June 29, 2018 12:56
@ehelms
Copy link
Contributor Author

ehelms commented Jun 29, 2018

@samdoran @gundalow Updated addressing comments.

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed ci_verified Changes made in this PR are causing tests to fail. small_patch labels Jun 29, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@mattclay
Copy link
Member

These paths need to be updated:

ansible/test/sanity/validate-modules/ignore.txt

Lines 1087 to 1090 in a342538

lib/ansible/modules/remote_management/foreman/foreman.py E322
lib/ansible/modules/remote_management/foreman/foreman.py E325
lib/ansible/modules/remote_management/foreman/katello.py E322
lib/ansible/modules/remote_management/foreman/katello.py E325

ansible/test/sanity/pylint/ignore.txt

Lines 56 to 57 in 858a1b0

lib/ansible/modules/remote_management/foreman/foreman.py ansible-format-automatic-specification
lib/ansible/modules/remote_management/foreman/katello.py ansible-format-automatic-specification

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jun 29, 2018
@jamescassell
Copy link
Contributor

I see that the linked repo lists one of its goals as "repository maintainers will be working to push the modules into Ansible proper". Is that still the case?

@ehelms
Copy link
Contributor Author

ehelms commented Jul 2, 2018

@jamescassell Yes. We have not pushed any yet as we've been hardening the module_utils layer and figuring out testing so they are as stable as possible. We are close to having some worthy of being pushed and managed in Ansible proper.

@FloThinksPi FloThinksPi mentioned this pull request Jul 2, 2018
Merged
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 18, 2018
@sean797 sean797 mentioned this pull request Aug 22, 2018
Closed
@sean797
Copy link

sean797 commented Aug 22, 2018

ping @ehelms this needs to be rebased.

@acozine acozine added this to To do in OLD Ansible Documentation via automation Sep 17, 2018
@acozine acozine moved this from To do to In progress in OLD Ansible Documentation Sep 17, 2018
@ansibot ansibot added test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 17, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 17, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 18, 2018
@acozine
Copy link
Contributor

acozine commented Sep 19, 2018

Rebased and moved to 2.8, since this PR missed the deadline for 2.7.

@acozine acozine merged commit 74b94e1 into ansible:devel Sep 19, 2018
@acozine acozine moved this from In progress to Done in OLD Ansible Documentation Sep 20, 2018
@acozine acozine added affects_2.8 This issue/PR affects Ansible v2.8 and removed affects_2.7 This issue/PR affects Ansible v2.7 labels Sep 20, 2018
@arsenicks arsenicks mentioned this pull request Dec 10, 2018
Closed
@dagwieers dagwieers added the foreman Foreman community label Feb 8, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@samdoran samdoran samdoran approved these changes

@FloThinksPi FloThinksPi FloThinksPi approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. foreman Foreman community module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
OLD Ansible Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ehelms @ansibot @mattclay @jamescassell @gundalow @sean797 @acozine @samdoran @FloThinksPi @dagwieers