Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipa_group: Adds description to module documentation #42080

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

fxfitz
Copy link
Contributor

@fxfitz fxfitz commented Jun 28, 2018

SUMMARY

I noticed today that we didn't have this in the documentation, despite it being available as a valid module argument.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ipa_group

ANSIBLE VERSION
ansible 2.7.0.dev0 (ipa_group_description 9875d20bb5) last updated 2018/06/28 16:30:08 (GMT -500)
  config file = None
  configured module search path = [u'/Users/fxfitz/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/fxfitz/dev/ansible/lib/ansible
to  executable location = /Users/fxfitz/.pyenv/versions/ansible/bin/ansible
  python version = 2.7.15 (default, May 29 2018, 20:16:38) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.1)]
ADDITIONAL INFORMATION

Not Applicable

@fxfitz fxfitz changed the title Adds description of the group to documentation ipa_group: Adds description to module documentation Jun 28, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/identity/ipa/ipa_group.py:0:0: E309 version_added for new option (description) should be 2.7. Currently 0.0

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 28, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 28, 2018
@fxfitz
Copy link
Contributor Author

fxfitz commented Jun 28, 2018

bot_broken

@fxfitz
Copy link
Contributor Author

fxfitz commented Jun 28, 2018

Going to say the bot is broken in this case, even though maybe not really, just because this just seems to be missing the documentation for the argument.

description wasn't added in 2.7, just it's documentation was. :-)

@ansibot ansibot added the bot_broken The bot is misbehaving. NOT for failing CI. A staff member will investigate. label Jun 28, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Jun 28, 2018
@gundalow
Copy link
Contributor

Bot isn't broken, test is incorrectly erroring. Though the error will go away post-merge

@gundalow gundalow merged commit 8876416 into ansible:devel Jun 28, 2018
@fxfitz
Copy link
Contributor Author

fxfitz commented Jun 28, 2018

Thanks @gundalow!

@dagwieers dagwieers added the ipa IPA community label Feb 8, 2019
@ansible ansible locked and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bot_broken The bot is misbehaving. NOT for failing CI. A staff member will investigate. ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. ipa IPA community module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants