Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meraki - Change idempotency check to be single pass #42087

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Meraki - Change idempotency check to be single pass #42087

merged 1 commit into from
Jul 3, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 29, 2018

SUMMARY
  • Previously all data between both data structures was compared
  • Results in situations where updates are done when not needed
  • Changes to single pass so only data in payload is compared

Fixes #41944

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki

ANSIBLE VERSION
ansible 2.7.0.dev0 (meraki/bug-41944 6d6b3e8b32) last updated 2018/06/26 06:57:36 (GMT -500)
  config file = None
  configured module search path = ['/Users/kbreit/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/kbreit/Documents/Programming/ansible/lib/ansible
  executable location = /Users/kbreit/Documents/Programming/ansible/bin/ansible
  python version = 3.5.4 (default, Feb 25 2018, 14:56:02) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@kbreit
Change idempotency check to be single pass
d4e3694 
- Previously all data between both data structures was compared
- Results in situations where updates are done when not needed
- Changes to single pass so only data in payload is compared
@ansibot
Copy link
Contributor

ansibot commented Jun 29, 2018

cc @Qalthos @dagwieers @ganeshrn @gdpak @gundalow @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. meraki Cisco Meraki community needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Jun 29, 2018
@kbreit kbreit changed the title Change idempotency check to be single pass Meraki -Change idempotency check to be single pass Jun 29, 2018
@kbreit kbreit changed the title Meraki -Change idempotency check to be single pass Meraki - Change idempotency check to be single pass Jun 29, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 29, 2018
@dagwieers
Copy link
Contributor

@kbreit This is something you should be able to merge IMO

@dagwieers
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2018

Components

lib/ansible/module_utils/network/meraki/meraki.py
support: community
maintainers: Qalthos dagwieers ganeshrn gdpak gundalow kbreit privateip rcarrillocruz trishnaguha

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): kbreit
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@dagwieers
Copy link
Contributor

shipit

@ansibot ansibot added the shipit This PR is ready to be merged by Core label Jul 2, 2018
@kbreit
Copy link
Contributor Author

kbreit commented Jul 3, 2018

shipit

@dagwieers
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jul 3, 2018

Components

lib/ansible/module_utils/network/meraki/meraki.py
support: community
maintainers: Qalthos dagwieers ganeshrn gdpak gundalow kbreit privateip rcarrillocruz trishnaguha

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): dagwieers kbreit
shipit_actors_other: []
automerge: automerge is_module test failed

click here for bot help

@dagwieers dagwieers merged commit 3ee3fc8 into ansible:devel Jul 3, 2018
@kbreit kbreit deleted the meraki/bug-41944 branch July 3, 2018 03:21
kbreit added a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@kbreit
Change idempotency check to be single pass (ansible#42087)
82f0c76 
- Previously all data between both data structures was compared
- Results in situations where updates are done when not needed
- Changes to single pass so only data in payload is compared

(cherry picked from commit 3ee3fc8)
mattclay pushed a commit that referenced this pull request Jul 3, 2018
@kbreit @mattclay
Change idempotency check to be single pass (#42087)
e436806 
- Previously all data between both data structures was compared
- Results in situations where updates are done when not needed
- Changes to single pass so only data in payload is compared

(cherry picked from commit 3ee3fc8)
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies meraki Cisco Meraki community networking Network category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meraki - Idempotency check is broken
4 participants
@kbreit @ansibot @dagwieers @mkrizek