Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix galaxy client executing queries with invalid http method #42201

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Fix galaxy client executing queries with invalid http method #42201

merged 1 commit into from
Jul 2, 2018

Conversation

cutwater
Copy link
Contributor

@cutwater cutwater commented Jul 2, 2018

Fixes: ansible/galaxy#796

SUMMARY

Galaxy API client relied on implicit mechanism that determined method for http requests. If data= field was specified, 'POST' method was automatically used.
This behaviour had changed after http layer in ansible/module_utils/urls.py got updated.

This patch adds explicit http method argument for Galaxy API client where it's required.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

ANSIBLE VERSION
ansible 2.7.0.dev0 (fix/galaxy-client 6e79419f15) last updated 2018/07/02 17:45:35 (GMT +200)
  config file = /Users/cutwater/.ansible.cfg
  configured module search path = [u'/Users/cutwater/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/cutwater/work/rh/ansible/lib/ansible
  executable location = /Users/cutwater/work/rh/ansible/.venv/bin/ansible
  python version = 2.7.13 (default, Feb 15 2017, 15:26:02) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)]

@chouseknecht
Copy link
Contributor

shipit

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 2, 2018
@chouseknecht chouseknecht merged commit 1eea567 into ansible:devel Jul 2, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jul 5, 2018
@ansible ansible locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible 2.7.0 - client import command fail
4 participants
@cutwater @chouseknecht @ansibot @jborean93