Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set the correct key option in the docs #42251

Merged
merged 1 commit into from Jul 3, 2018
Merged

Fix set the correct key option in the docs #42251

merged 1 commit into from Jul 3, 2018

Conversation

grouchoboy
Copy link
Contributor

SUMMARY

Under the network dictionary the key expected is subnet_mask not netmask.

ansible/lib/ansible/modules/cloud/vmware/vmware_vmkernel.py

Line 180 in 0a6ab23

self.subnet_mask = self.params['network'].get('subnet_mask', None)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

This change will affect the vmware_vmkernel module.

ANSIBLE VERSION
ansible 2.5.1
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.6/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.6.5 (default, Apr 10 2018, 17:08:37) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 3, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jul 3, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jul 3, 2018
@Akasurde Akasurde merged commit 313e7ba into ansible:devel Jul 3, 2018
@Akasurde
Copy link
Member

Akasurde commented Jul 3, 2018

@grouchoboy Thanks for the contribution.

@ansible ansible locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grouchoboy @ansibot @Akasurde