Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching old style facts in junos_facts module #42336

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Fix fetching old style facts in junos_facts module #42336

merged 3 commits into from
Jul 5, 2018

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Jul 5, 2018

SUMMARY

Fixes #42298

  • To fetch old style facts from junos device it requires
    login credentials in provider, hence while using
    connection=nectonf do not delete provider values
    as it might not be ignored

  • Add ofacts as one of the options in gather_subset

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@ganeshrn
Fix fetching old style facts in junos_facts module
717b820 
Fixes ansible#42298
* To fetch old style facts from junos device it requires
  login credentials in provider, hence while using
  connection=nectonf do not delete provider values
  as it might not be ignored

* Add `ofacts` as one of the options in `gather_subset`
@ganeshrn
Minor update in documentation
80ba011
@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2018

cc @Qalthos @gdpak @gundalow @privateip @Qalthos @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 5, 2018
@ansible ansible deleted a comment from ansibot Jul 5, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Jul 5, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 5, 2018
@justjais justjais merged commit 31dd41e into ansible:devel Jul 5, 2018
@justjais justjais mentioned this pull request Jul 5, 2018
Closed
@ganeshrn ganeshrn deleted the junos_old_facts_fix branch July 5, 2018 13:10
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request Jul 5, 2018
@ganeshrn
Fix fetching old style facts in junos_facts module (ansible#42336)
bd97356 
* Fix fetching old style facts in junos_facts module

Fixes ansible#42298
* To fetch old style facts from junos device it requires
  login credentials in provider, hence while using
  connection=nectonf do not delete provider values
  as it might not be ignored

* Add `ofacts` as one of the options in `gather_subset`

* Minor update in documentation

* Fix CI failure

(cherry picked from commit 31dd41e)
mattclay pushed a commit that referenced this pull request Jul 9, 2018
@ganeshrn @mattclay
Fix fetching old style facts in junos_facts module (#42336) (#42351)
9ed5e70 
* Fix fetching old style facts in junos_facts module (#42336)

* Fix fetching old style facts in junos_facts module

Fixes #42298
* To fetch old style facts from junos device it requires
  login credentials in provider, hence while using
  connection=nectonf do not delete provider values
  as it might not be ignored

* Add `ofacts` as one of the options in `gather_subset`

* Minor update in documentation

* Fix CI failure

(cherry picked from commit 31dd41e)

* Update changelog
@ansible ansible locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use the junos_facts module with netconf connection
3 participants
@ganeshrn @ansibot @justjais