Define module for managing LDAP authentication for E-Series #42356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
hulquest
reviewed
Jul 5, 2018
|
|
||
| return domain | ||
|
|
||
| def is_embedded(self): |
There was a problem hiding this comment.
Could this be moved to the common fragment? I don't think it's a must-fix for this PR.
There was a problem hiding this comment.
I think that's a good idea, but let's get this one merged first. I'll add the common code after all of the other changes to the common code in netapp utils file.
There was a problem hiding this comment.
@lmprice Reminder that this may need moving to common code
|
The test The test The test The test The test |
ansibot
added
needs_revision
mattclay
reviewed
Jul 5, 2018
lib/ansible/module_utils/netapp.py
Outdated
| @@ -35,6 +35,7 @@ | |||
| from ansible.module_utils.six.moves.urllib.error import HTTPError | |||
| from ansible.module_utils.urls import open_url | |||
| from ansible.module_utils.api import basic_auth_argument_spec | |||
| from ansible.release import __version__ as ansible_version | |||
There was a problem hiding this comment.
Use this instead:
from ansible.module_utils.ansible_release import __version__There was a problem hiding this comment.
Got it. I was guessing on the best place to pull that information.
ansibot
added
core_review
|
shipit |
ansibot
added
shipit
ansibot
added
core_review
|
shipit |
ansibot
removed
the
core_review
ansibot
added
needs_rebase
|
@lmprice this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibot
added
the
merge_commit
|
Can you please rebase this by following http://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html Thanks in advance |
ansibot
removed
merge_commit
|
The test |
|
The test |
ansibot
removed
the
ci_verified
|
This is an expected failure. Waiting on #44659 to merge. |
|
The test |
This module will allow users to manage LDAP authentication domains for accessing E-Series systems.
ansibot
removed
the
ci_verified
|
The test |
ansibot
added
ci_verified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module will allow users to manage LDAP authentication domains for
accessing E-Series systems.
SUMMARY
This is a new module to allow an owner of an E-Series system to manage the LDAP authentication domains that can be utilized for logging into the system.
ISSUE TYPE
COMPONENT NAME
netapp_e_ldap
ANSIBLE VERSION
ADDITIONAL INFORMATION