docker_container: fix check mode for container creation #42380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
samdoran
removed
the
needs_triage
kassiansun
reviewed
Jul 6, 2018
| # derived from dict, which ansible cannot convert to JSON correctly. | ||
| # Therefore, we make sure we copy it to turn it into a regular dict. | ||
| debug_parameters = dict(create_parameters) | ||
| debug_parameters['host_config'] = dict(debug_parameters['host_config']) |
There was a problem hiding this comment.
Add a helper for recursive converting anything with an underlying type of dict?
There was a problem hiding this comment.
Is 6c3acc8 doing what you were thinking of?
…eturn values of docker_container.
ansibot
added
core_review
kassiansun
approved these changes
Jul 6, 2018
|
shipit |
ansibot
added
the
stale_ci
felixfontein
changed the title
|
shipit |
|
bot_status |
Componentslib/ansible/module_utils/docker_common.py lib/ansible/modules/cloud/docker/docker_container.py Metadatawaiting_on: ansible |
ansibot
added
shipit
|
|
|
@gundalow Thanks for merging! |
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Aug 28, 2018
* Create copy of HostConfig object before adding it to results. * Create general sanitize function in docker_common. Using it for all return values of docker_container. * Make Python 2.6 compatible.
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Sep 1, 2018
mattclay
pushed a commit
that referenced
this pull request
Sep 4, 2018
* docker_container: fix check mode for container creation (#42380) * Create copy of HostConfig object before adding it to results. * Create general sanitize function in docker_common. Using it for all return values of docker_container. * Make Python 2.6 compatible. * Added changelog.
abadger
pushed a commit
that referenced
this pull request
Sep 6, 2018
ndswartz
pushed a commit
to ndswartz/ansible
that referenced
this pull request
Nov 28, 2018
* Add changelog entry for ansible#16748. * Changelog entry for ansible#33579. * Added changelog for ansible#42380. * Added changelog for ansible#42641. * Adding changelog entry for ansible#42857. * Added changelog for ansible#44808.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently,
docker_containerwill die when creating a container in check mode or debug mode (see #33578). The problem is that adocker.types.containers.HostConfigobject is added to results (as part ofself.parameters.create_parameters), which Ansible's JSON sanitizing code cannot handle.Fixes #33578.
ISSUE TYPE
COMPONENT NAME
docker_container
ANSIBLE VERSION
(I've used both 2.6 and the
develbranch to reproduce this, but the bug has already been reported for 2.4.2; see #33578)