Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: fix vlan connection modification Fixes #42322 #42415

Merged
merged 2 commits into from
Oct 11, 2018
Merged

nmcli: fix vlan connection modification Fixes #42322 #42415

merged 2 commits into from
Oct 11, 2018

Conversation

dangoscomb
Copy link
Contributor

fix syntax of vlan modification command

SUMMARY

fix command syntax for nmcli con mod command

set None values on params to '' in order to remove previously set values (and result in syntactically correct commands)

Fixes #42322

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nmcli

ANSIBLE VERSION

current version below, however nmcli taken from devel branch

ansible 2.5.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/ansible/lib']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Apr 11 2018, 07:36:10) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 6, 2018

cc @alcamie101
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 6, 2018
@Akasurde
Copy link
Member

Akasurde commented Jul 6, 2018

@dangoscomb Thanks for the PR. Could you please add unit test here ?

Thanks,

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 6, 2018
@dangoscomb
Copy link
Contributor Author

@Akasurde amended the 2 tests as requested. They run fine locally

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 6, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 15, 2018
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Sep 17, 2018
@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. labels Oct 3, 2018
@Shaps
Copy link
Contributor

Shaps commented Oct 10, 2018

bot_status

1 similar comment
@gundalow
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2018

Components

lib/ansible/modules/net_tools/nmcli.py
support: community
maintainers:

test/units/modules/net_tools/test_nmcli.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@Shaps
Copy link
Contributor

Shaps commented Oct 10, 2018

shipit

@gundalow gundalow changed the title fix vlan connection modifcation in nmcli module Fixes #42322 nmcli: fix vlan connection modifcation in nmcli module Fixes #42322 Oct 11, 2018
@gundalow gundalow changed the title nmcli: fix vlan connection modifcation in nmcli module Fixes #42322 nmcli: fix vlan connection modification Fixes #42322 Oct 11, 2018
@gundalow
Copy link
Contributor

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 11, 2018
@ansibot ansibot merged commit fb72a54 into ansible:devel Oct 11, 2018
Shaps pushed a commit to Shaps/ansible that referenced this pull request Oct 11, 2018
@dangoscomb @Shaps
nmcli: fix vlan connection modification Fixes ansible#42322 (ansible#…
181fca8 
…42415)

* ensure optional items are set to empty strings rather than not presented
fix syntax of vlan modification command

* extended tests for nmcli

(cherry picked from commit fb72a54)
@Shaps Shaps mentioned this pull request Oct 11, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 11, 2018
@Shaps @abadger
[2.7] nmcli: backport of #42415 (#46814)
ebc35bd 
* nmcli: fix vlan connection modification Fixes #42322 (#42415)

* ensure optional items are set to empty strings rather than not presented
fix syntax of vlan modification command

* extended tests for nmcli

(cherry picked from commit fb72a54)

* Changelog fragment for nmcli fix
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@dangoscomb @Tomorrow9
nmcli: fix vlan connection modification Fixes ansible#42322 (ansible#…
6f637d9 
…42415)

* ensure optional items are set to empty strings rather than not presented
fix syntax of vlan modification command

* extended tests for nmcli
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmcli modify_connection_vlan() function seems broken
5 participants
@dangoscomb @ansibot @Akasurde @Shaps @gundalow