Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vultr: Introducing vr_region_facts module #42471

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Vultr: Introducing vr_region_facts module #42471

merged 1 commit into from
Jul 18, 2018

Conversation

Spredzy
Copy link
Contributor

@Spredzy Spredzy commented Jul 8, 2018 •
edited

SUMMARY

This commit introduces a new module called vr_region_facts.

This module aims to return the list of region avaiable avaiable to use
where boot servers.

Sample available here:

"vultr_region_facts": [
  [
    {
      "block_storage": false,
      "continent": "Europe",
      "country": "FR",
      "ddos_protection": true,
      "id": 24,
      "name": "Paris",
      "regioncode": "CDG",
      "state": ""
     }
  ]
]
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • vr_region_facts
ANSIBLE VERSION
  • devel
ADDITIONAL INFORMATION
  • N/A

@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2018

cc @mattclay @resmo
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 8, 2018
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 8, 2018
mattclay
mattclay reviewed Jul 9, 2018
View reviewed changes
test/sanity/validate-modules/ignore.txt Outdated
@@ -520,6 +520,7 @@ lib/ansible/modules/cloud/vultr/vr_dns_record.py E326
lib/ansible/modules/cloud/vultr/vr_firewall_group.py E324
lib/ansible/modules/cloud/vultr/vr_firewall_rule.py E323
lib/ansible/modules/cloud/vultr/vr_firewall_rule.py E324
lib/ansible/modules/cloud/vultr/vr_region_facts.py E324
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New ignores should not be added. Instead, the underlying issue should be fixed.

If the issue is in existing common code (docs fragments or module_utils), then the fix should be in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattclay agree. I did that while #42464 gets merged, so the CI feedback is green. Once merged, I'll update this PR removing this line from here.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 9, 2018
@Spredzy Spredzy mentioned this pull request Jul 10, 2018
Merged
@Spredzy Spredzy force-pushed the vr_region_facts branch 2 times, most recently from 5e99d61 to 40ff7f2 Compare July 18, 2018 07:41
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 18, 2018
resmo
resmo approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 18, 2018
@Spredzy
Vultr: Introducing vr_region_facts module
c15843e 
This commit introduces a new module called vr_region_facts.

This module aims to return the list of region avaiable avaiable to use
where boot servers.

Sample available here:

```
"vultr_region_facts": [
    {
      "block_storage": false,
      "continent": "Europe",
      "country": "FR",
      "ddos_protection": true,
      "id": 24,
      "name": "Paris",
      "regioncode": "CDG",
      "state": ""
     }
  ]
```
@resmo
Copy link
Contributor

resmo commented Jul 18, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 18, 2018
@resmo resmo merged commit 11fd20b into ansible:devel Jul 18, 2018
@dagwieers dagwieers added the vultr Vultr community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay left review comments

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Spredzy @ansibot @resmo @mattclay @dagwieers