Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme_certificate/letsencrypt: fixing deprecation message #42496

Merged
merged 1 commit into from Jul 9, 2018
Merged

acme_certificate/letsencrypt: fixing deprecation message #42496

merged 1 commit into from Jul 9, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

As can be seen in #42495, the warning message claims that the feature will be removed in 2.1 instead of 2.10.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acme_certificate
letsencrypt

ANSIBLE VERSION
2.6.1

@ansibot
Copy link
Contributor

ansibot commented Jul 9, 2018

cc @mgruener @resmo
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jul 9, 2018
@resmo
Copy link
Contributor

resmo commented Jul 9, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 9, 2018
@ansibot ansibot merged commit dbb58b3 into ansible:devel Jul 9, 2018
@felixfontein
Copy link
Contributor Author

@resmo thanks for handling this! Do you want to create a backport branch for 2.6, or should I do that?

@felixfontein felixfontein deleted the acme-fix-deprecation-warning branch July 9, 2018 11:01
@resmo
Copy link
Contributor

resmo commented Jul 9, 2018

@felixfontein would appreciate if you do it

felixfontein added a commit to felixfontein/ansible that referenced this pull request Jul 9, 2018
@felixfontein
Version must be quoted (otherwise it is printed as 2.1) (ansible#42496)
8a046af
@felixfontein felixfontein mentioned this pull request Jul 9, 2018
Merged
@felixfontein
Copy link
Contributor Author

Done, see #42502.

@felixfontein felixfontein mentioned this pull request Jul 11, 2018
Merged
mattclay pushed a commit that referenced this pull request Jul 17, 2018
@felixfontein @mattclay
Version must be quoted (otherwise it is printed as 2.1) (#42496)
27e57e4
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @resmo @dagwieers