Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define netapp_e_mgmt_interface storage module. #42519

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Define netapp_e_mgmt_interface storage module. #42519

merged 2 commits into from
Aug 28, 2018

Conversation

ndswartz
Copy link
Contributor

@ndswartz ndswartz commented Jul 9, 2018

SUMMARY

The netapp_e_mgmt_interface module provides management configuration for
e-series storage array interface points including remote ssh access, NTP
and DNS services.

This patch also includes integration and unit tests.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

netapp_e_mgmt_interface

ANSIBLE VERSION
ansible 2.7.0.dev0 (mgmt_testing_pub c09b1843c5) last updated 2018/07/09 10:33:34 (GMT -500)
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible/lib/ansible
  executable location = /home/swartzn/ansible/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 9, 2018

cc @amit0701 @carchi8py @hulquest @lmprice @mattclay @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 9, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 9, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 9, 2018
lmprice
lmprice approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@lmprice lmprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 9, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Jul 13, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 23, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 26, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 4, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 23, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/strategy/__init__.py:829:161: E501 line too long (165 > 160 characters)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 23, 2018
@ndswartz ndswartz closed this Aug 24, 2018
@ndswartz ndswartz reopened this Aug 24, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 24, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 24, 2018
@swartzn
Define netapp_e_mgmt_interface storage module.
b59cff3 
The netapp_e_mgmt_interface module provides management configuration for
e-series storage array interface points including remote ssh access, NTP
and DNS services.

This patch also includes integration and unit tests.
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py:31:78: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. labels Aug 28, 2018
gundalow
gundalow requested changes Aug 28, 2018
View reviewed changes
lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py
that are present in the system.
- The name represents the port number (typically from left to right on the controller),
beginning with a value of 1.
- Mutually exclusive with I(channel).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the following to argument_spec
mutually_exclusive=(['name', 'channel'],),

lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py
- The port to modify the configuration for.
- The channel represents the port number (typically from left to right on the controller),
beginning with a value of 1.
- Mutually exclusive with I(name).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding code to check this and call fail_json if it isn't allowed

lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py Outdated
description:
- Enable ssh access to the controller for debug purposes.
- This is a controller-level setting.
- Older controllers may enable rlogin or telnet instead of ssh.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this modules will do...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing if you're not familiar with the E-Series systems. This option will enable/disable telnet or ssh, depending on the age/model of the E-Series system that's being managed. Perhaps it's worded poorly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 28, 2018
@gundalow gundalow merged commit d31e25a into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow requested changes

@lmprice lmprice lmprice approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ndswartz @ansibot @gundalow @lmprice @bcoca @swartzn