Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define netapp_e_auditlog storage module. #42535

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Define netapp_e_auditlog storage module. #42535

merged 1 commit into from
Aug 28, 2018

Conversation

ndswartz
Copy link
Contributor

@ndswartz ndswartz commented Jul 9, 2018

SUMMARY

This module allows NetApp E-Series storage system's audit-log feature to be configured.

This patch also includes integration and unit tests.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

netapp_e_auditlog

ANSIBLE VERSION
ansible 2.7.0.dev0 (auditlog_pub 276d2393d8) last updated 2018/07/09 15:56:28 (GMT -500)
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible/lib/ansible
  executable location = /home/swartzn/ansible/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 9, 2018

cc @amit0701 @carchi8py @hulquest @lmprice @mattclay @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 9, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 9, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/storage/netapp/netapp_e_auditlog.py:76:1: W293 blank line contains whitespace
lib/ansible/modules/storage/netapp/netapp_e_auditlog.py:83:1: W293 blank line contains whitespace

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 9, 2018
@ndswartz ndswartz force-pushed the auditlog_pub branch 3 times, most recently from e284410 to 6703cdb Compare July 10, 2018 01:17
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 10, 2018
lmprice
lmprice approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@lmprice lmprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 10, 2018
@gundalow
Copy link
Contributor

Rebase needed https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Aug 24, 2018
@swartzn
Define netapp_e_auditlog storage module.
d415966 
This module allows NetApp E-Series storage system's audit-log feature to be configured.
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_auditlog.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 24, 2018
@gundalow gundalow merged commit cf41415 into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@lmprice lmprice lmprice approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ndswartz @ansibot @gundalow @lmprice @bcoca @swartzn