Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_file: Don't leave leftover files behind #42622

Merged
merged 3 commits into from Jul 12, 2018
Merged

ios_file: Don't leave leftover files behind #42622

merged 3 commits into from Jul 12, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Jul 11, 2018

SUMMARY

There are also some Python 3 issues that need to be addressed

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

net_put/net_get

ANSIBLE VERSION
2.7

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 11, 2018
@Qalthos Qalthos requested a review from gdpak July 11, 2018 16:47
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2018
@Qalthos Qalthos changed the title [WIP] ios_file: Don't leave leftover files behind ios_file: Don't leave leftover files behind Jul 11, 2018
@ansibot ansibot removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jul 11, 2018
gdpak
gdpak approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@gdpak gdpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gdpak gdpak merged commit 6b16214 into ansible:devel Jul 12, 2018
gdpak pushed a commit to gdpak/ansible that referenced this pull request Jul 12, 2018
@Qalthos @gdpak
ios_file: Don't leave leftover files behind (ansible#42622)
523caae 
* Don't leave leftover files behind

* Fix writing files in python3

* Replace nonascii.bin with one that will not pass for unicode

(cherry picked from commit 6b16214)
@Qalthos Qalthos deleted the ios-fixes branch July 12, 2018 12:40
@gdpak gdpak mentioned this pull request Jul 17, 2018
Closed
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdpak gdpak gdpak approved these changes

Assignees

@gdpak gdpak

Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies ios Cisco IOS community networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Qalthos @gdpak @dagwieers @gundalow @ansibot