Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos facts integration test failures #42623

Merged
merged 1 commit into from Jul 12, 2018
Merged

Fix junos facts integration test failures #42623

merged 1 commit into from Jul 12, 2018

Conversation

ganeshrn
Copy link
Member

SUMMARY
  • Make fetching old style facts optional
    and try to fetch the old style facts only when
    ofacts value is present in gather_facts
  • Fix in junos_facts integration test
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@ganeshrn
Fix junos facts integration test failures
f266542 
*  Make fetching old style facts optional
   and try to fetch the old style facts only when
   `ofacts` value is present in `gather_facts`
* Fix in junos_facts integration test
@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2018

cc @Qalthos @Qalthos
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jul 11, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2018
@ganeshrn ganeshrn merged commit 6a94090 into ansible:devel Jul 12, 2018
@ganeshrn ganeshrn deleted the junos_it_fix branch July 12, 2018 04:23
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganeshrn @ansibot