Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define module for managing E-Series email alerts #42643

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Define module for managing E-Series email alerts #42643

merged 1 commit into from
Aug 28, 2018

Conversation

lmprice
Copy link
Contributor

@lmprice lmprice commented Jul 11, 2018

SUMMARY

Email alerts can be enabled for an E-Series system to provide
information to interested users by email when a warning or critical
level event occurs on the system. This module will allow a system owner
to configure whether or not system alerts are enabled, and who will
receive them.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

netapp_e_alerts

ANSIBLE VERSION
ansible 2.6.0 (detached HEAD ce8c336d52) last updated 2018/04/18 11:23:03 (GMT -500)
  config file = None
  configured module search path = [u'/home/lorenp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/lorenp/ansible/lib/ansible
  executable location = /home/lorenp/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2018

cc @amit0701 @carchi8py @hulquest @mattclay @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 11, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2018
ndswartz
ndswartz approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@ndswartz ndswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 13, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Aug 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 23, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/strategy/__init__.py:829:161: E501 line too long (165 > 160 characters)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 23, 2018
@mattclay
Copy link
Member

The sanity failure is unrelated and has been fixed. I've restarted CI.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 24, 2018
gundalow
gundalow requested changes Aug 24, 2018
View reviewed changes
lib/ansible/modules/storage/netapp/netapp_e_alerts.py
- Enable/disable the sending of email-based alerts.
default: enabled
required: false
choices:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be enabled/disabled?

What's present/absent mean?

lib/ansible/modules/storage/netapp/netapp_e_alerts.py Outdated
- A fully qualified domain name, IPv4 address, or IPv6 address of a mail server.
- To use a fully qualified domain name, you must configure a DNS server on both controllers using
M(netapp_e_mgmt_interface).
- Required when I(state=enabled/present).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's confusing having enabled and present

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to have consistency with all of the other places that state is utilized in Ansible modules. state=present/absent seems to be a common convention elsewhere (hence why prior developers used it in our volume module, for instance).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though the issue is you are supporting both present and enabled. What's the difference?
Just pick one pair and use that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled/disabled for this as we are talking about a service (email)

lib/ansible/modules/storage/netapp/netapp_e_alerts.py Outdated
type: bool
log_path:
description:
- A local path to a file to be used for debug logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local to what?
The Ansible Controller?

gundalow
gundalow reviewed Aug 28, 2018
View reviewed changes
lib/ansible/utils/module_docs_fragments/netapp.py Outdated
ssid:
required: true
description:
- The ID of the array to manage. This value must be unique for each array.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this needs updating do it in it's own PR

@lmprice
Define module for managing E-Series email alerts
e4fcb4c 
Email alerts can be enabled for an E-Series system to provide
information to interested users by email when a warning or critical
level event occurs on the system. This module will allow a system owner
to configure whether or not system alerts are enabled, and who will
receive them.
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 28, 2018
@lmprice
Copy link
Contributor Author

lmprice commented Aug 28, 2018

@gundalow The requested changes have been completed. Let me know if I missed something.

@gundalow gundalow merged commit 054b87a into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@ndswartz ndswartz ndswartz approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lmprice @ansibot @mattclay @gundalow @ndswartz @jborean93