Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zabbix inventory improvement #42669

Merged
merged 4 commits into from Jul 14, 2018
Merged

Zabbix inventory improvement #42669

merged 4 commits into from Jul 14, 2018

Conversation

Filippo125
Copy link
Contributor

SUMMARY

Add capability to connect with zabbix server ignoring ssl certificate

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

dynamic inventory

ANSIBLE VERSION
ansible 2.6.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.13 (default, Nov 24 2017, 17:33:09) [GCC 6.3.0 20170516]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 c:inventory/contrib_script feature This issue/PR relates to a feature request. inventory Inventory category needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2018

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

contrib/inventory/zabbix.py:77:38: E231 missing whitespace after ','
contrib/inventory/zabbix.py:78:35: E231 missing whitespace after ','
contrib/inventory/zabbix.py:133:58: E231 missing whitespace after ','

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 12, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 12, 2018
@Filippo125
Copy link
Contributor Author

ready_for_review

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 12, 2018
@samdoran
Copy link
Contributor

Please create a changelog fragment. See fragments for examples.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2018
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jul 13, 2018
@samdoran samdoran merged commit 5864871 into ansible:devel Jul 14, 2018
@dagwieers dagwieers added the zabbix Zabbix community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 c:inventory/contrib_script feature This issue/PR relates to a feature request. inventory Inventory category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Filippo125 @ansibot @samdoran @dagwieers