Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error messasge #42770

Merged
merged 2 commits into from
Jul 19, 2018
Merged

better error messasge #42770

merged 2 commits into from
Jul 19, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 13, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

atomic move

ANSIBLE VERSION
2.x

@abadger
Copy link
Contributor

abadger commented Jul 13, 2018

+1

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. shipit This PR is ready to be merged by Core small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 13, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 13, 2018
@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Jul 13, 2018
@ansibot ansibot removed shipit This PR is ready to be merged by Core small_patch labels Jul 13, 2018
@maxamillion
Copy link
Contributor

maxamillion commented Jul 13, 2018 •
edited

LGTM 👍

shipit

@ansibot ansibot added the shipit This PR is ready to be merged by Core label Jul 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 13, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/basic.py:2621:161: E501 line too long (164 > 160 characters)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Jul 13, 2018
@bcoca bcoca removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 17, 2018
@bcoca bcoca merged commit 9217fbb into ansible:devel Jul 19, 2018
@bcoca bcoca deleted the better_atomic_msg branch July 19, 2018 16:13
bcoca added a commit to bcoca/ansible that referenced this pull request Jul 19, 2018
@bcoca
better error messasge (ansible#42770)
1e792f5 
* better error messasge

(cherry picked from commit 9217fbb)
@bcoca bcoca mentioned this pull request Jul 19, 2018
Merged
mattclay pushed a commit that referenced this pull request Jul 27, 2018
@bcoca @mattclay
better error messasge (#42770)
c622cc6 
* better error messasge

(cherry picked from commit 9217fbb)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.5.x blocker list
  
To Do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @abadger @maxamillion @ansibot