Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for GCP Spanner Instances #42800

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Adding support for GCP Spanner Instances #42800

merged 1 commit into from
Aug 28, 2018

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

Adding support for GCP Spanner Instances

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_spanner_instance

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

This was autogenerated using Magic Modules

@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2018

cc @erjohnso
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jul 15, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2018

@GwenaelPellenArkeup @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @nitaco @robwagner33 @supertom @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 6, 2018
@rambleraptor rambleraptor force-pushed the gcp_spanner_instance branch 2 times, most recently from 4ff5930 to 64306d9 Compare August 6, 2018 06:14
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 13, 2018
ryansb
ryansb reviewed Aug 13, 2018
View reviewed changes
lib/ansible/modules/cloud/google/gcp_spanner_instance.py
module = GcpModule(
argument_spec=dict(
state=dict(default='present', choices=['present', 'absent'], type='str'),
name=dict(type='str'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a display name also be required? Otherwise how would the API distinguish which instance is being referred to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look down a couple lines :)

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2018
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 27, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 27, 2018
@ryansb ryansb merged commit 48de2cf into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rambleraptor @ansibot @ryansb @jborean93