Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for GCP Sql Instances #42802

Merged
merged 1 commit into from Aug 28, 2018
Merged

Adding support for GCP Sql Instances #42802

merged 1 commit into from Aug 28, 2018

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

Adding support for GCP Sql Instances

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_sql_instance

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

This was autogenerated using Magic Modules

@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2018

cc @erjohnso
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jul 15, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2018

@GwenaelPellenArkeup @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @nitaco @robwagner33 @supertom @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 6, 2018
@rambleraptor rambleraptor force-pushed the gcp_sql_instance branch 2 times, most recently from 502dacd to 24fbc8f Compare August 6, 2018 06:14
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 13, 2018
@ryansb
Copy link
Contributor

ryansb commented Aug 13, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2018

Components

lib/ansible/module_utils/gcp_utils.py
support: core
maintainers:

lib/ansible/modules/cloud/google/gcp_sql_instance.py
support: community
maintainers: erjohnso rambleraptor

lib/ansible/utils/module_docs_fragments/gcp.py
support: core
maintainers:

test/integration/targets/gcp_sql_instance/aliases
support: community
maintainers:

test/integration/targets/gcp_sql_instance/defaults/main.yml
support: community
maintainers:

test/integration/targets/gcp_sql_instance/meta/main.yml
support: community
maintainers:

test/integration/targets/gcp_sql_instance/tasks/main.yml
support: community
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): rambleraptor
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 13, 2018
ryansb
ryansb suggested changes Aug 16, 2018
View reviewed changes
lib/ansible/modules/cloud/google/gcp_sql_instance.py
state=dict(default='present', choices=['present', 'absent'], type='str'),
backend_type=dict(type='str', choices=['FIRST_GEN', 'SECOND_GEN', 'EXTERNAL']),
connection_name=dict(type='str'),
database_version=dict(type='str', choices=['MYSQL_5_5', 'MYSQL_5_6', 'MYSQL_5_7', 'POSTGRES_9_6']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a dynamic way for these choices to be discovered, maybe a preflight call to a list of available DB's, so that when Postgres 9.7 or MySQL 5.8 is available, the module doesn't need to be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would think there would be. We don't seem to have an API to return it though.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 16, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 24, 2018
@ryansb ryansb merged commit 473b6db into ansible:devel Aug 28, 2018
@viper233
Copy link
Contributor

viper233 commented Oct 2, 2018

https://cloud.google.com/blog/products/databases/introducing-private-networking-connection-for-cloud-sql just saw that private ip space is now supported for a connection. I'll try to create an issue for it.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud gce module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rambleraptor @ansibot @ryansb @viper233 @jborean93