Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for GCP Dns Resource Record Sets #42832

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Bug fixes for GCP Dns Resource Record Sets #42832

merged 1 commit into from
Aug 28, 2018

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

Bug fixes for GCP Dns Resource Record Sets

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gcp_dns_resource_record_set

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

This was autogenerated using Magic Modules

@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2018

cc @erjohnso @GoogleCloudPlatform
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 15, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2018
@ansibot ansibot added test This PR relates to tests. and removed owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 6, 2018
@rambleraptor rambleraptor force-pushed the gcp_dns_resource_record_set branch 2 times, most recently from 265e967 to 8cf5507 Compare August 6, 2018 06:17
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/gcp_dns_resource_record_set/tasks/main.yml:27:3: key-duplicates duplication of key "register" in mapping

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 14, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/gcp_dns_resource_record_set/tasks/main.yml:27:3: key-duplicates duplication of key "register" in mapping

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 14, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/gcp_dns_resource_record_set/tasks/main.yml:27:3: key-duplicates duplication of key "register" in mapping

click here for bot help

@ryansb
Copy link
Contributor

ryansb commented Aug 22, 2018

@rambleraptor this is waiting on CI fixes on your end.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 22, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/gcp_dns_resource_record_set/tasks/main.yml:27:3: key-duplicates duplication of key "register" in mapping

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 27, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 27, 2018
@ryansb ryansb merged commit e9c9ccc into ansible:devel Aug 28, 2018
@dch
Copy link

dch commented Nov 27, 2018

@rambleraptor @ryansb while debugging an issue with this module, I found this commit rather confusing. For next time please can you add a more descriptive commit message? Also, I can see a large pile of doc and white-space related tweaks which would be much easier to separate out if they were a separate commit. Thanks!

@rambleraptor
Copy link
Contributor Author

will do!

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rambleraptor @ansibot @ryansb @dch @achinthagunasekara @jborean93