Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update sentence structure in user guide #42884

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Docs: Update sentence structure in user guide #42884

merged 3 commits into from
Jul 17, 2018

Conversation

taranjeet
Copy link
Contributor

SUMMARY

This commit fixes a grammatically incorrect sentence in
Introduction to Playbook Section under User Guide.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

User Guide > Introduction to Playbooks

This commit fixes a grammatically incorrect sentence in 
Introduction to Playbook Section under User Guide.
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 17, 2018
@@ -160,7 +160,7 @@ Support for running things as another user is also available (see :doc:`become`)
remote_user: yourname
become: yes

You can also use become on a particular task instead of the whole play::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rephrase this as -

You can also use keyword 'become' on a particular task instead of the whole play

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that suits better.

Copy link
Contributor Author

@taranjeet taranjeet Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the sentence now. Thanks @Akasurde for the suggestion

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jul 17, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 17, 2018
@acozine acozine self-requested a review July 17, 2018 14:53
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taranjeet, thank you for reading the documentation so carefully and for submitting a PR. We're committed to making the Ansible documentation world-class, and user feedback is an important part of that effort.

I think this change would be stronger if the word become were formatted as code - in rST, you do that with double back-ticks before and after the word.

For future documentation suggestions, please include a sentence or two in the PR letting us know what you found confusing or incorrect about the original wording. This will help us review and revise the user documentation.

This commit fixes the information about become keyword in
Introduction to Playbook part under User Guide.
@taranjeet
Copy link
Contributor Author

@acozine : I have updated the become keyword. Also, in the future, I will take care that my commit messages are more meaningful.

@Akasurde Akasurde merged commit 58d6044 into ansible:devel Jul 17, 2018
@Akasurde
Copy link
Member

@taranjeet Thanks for the contribution. @bcoca @acozine Thanks for the review.

@acozine acozine added this to To do in OLD Ansible Documentation via automation Jul 18, 2018
@acozine acozine moved this from To do to Done in OLD Ansible Documentation Jul 30, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants