Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vultr: Make get_result handle list #42890

Merged
merged 1 commit into from
Jul 17, 2018
Merged

vultr: Make get_result handle list #42890

merged 1 commit into from
Jul 17, 2018

Conversation

Spredzy
Copy link
Contributor

@Spredzy Spredzy commented Jul 17, 2018

SUMMARY

Currently get_result() can only handle list. When requiring facts, and
when there is more than one fact, get_result() should be able to handle
list, so the normalization process happens to all the items.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • vultr
ANSIBLE VERSION
  • devel
ADDITIONAL INFORMATION
  • N/A

@Spredzy
vultr: Make get_result handle list
9b42839 
Currently get_result() can only handle list. When requiring facts, and
when there is more than one fact, get_result() should be able to handle
list, so the normalization process happens to all the items.
@Spredzy
Copy link
Contributor Author

Spredzy commented Jul 17, 2018

cc @resmo

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 17, 2018
resmo
resmo approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added the shipit This PR is ready to be merged by Core label Jul 17, 2018
@resmo resmo merged commit 577427b into ansible:devel Jul 17, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
@dagwieers dagwieers added the vultr Vultr community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Spredzy @resmo @dagwieers @samdoran @ansibot