Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing QoS and source facts and fix for vVOLs in purefa_facts module #42919

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Add missing QoS and source facts and fix for vVOLs in purefa_facts module #42919

merged 1 commit into from
Aug 28, 2018

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Jul 17, 2018 •
edited

SUMMARY

Add missing QoS fact and source fact, which identifies where a volume was cloned from, for purefa_facts module. Fix error when vVOLs are present on an array which needs to correctly see protocol endpoints for VASA

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

storage/purestorage/purefa_facts

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels Jul 18, 2018
@sdodsley sdodsley force-pushed the purefa_facts_qos branch 2 times, most recently from 967b67b to 0c2be43 Compare July 18, 2018 02:41
@sdodsley sdodsley changed the title Add missing QoS and source facts for purefa_facts module Add missing QoS and source facts and fix for vVOLs in purefa_facts module Jul 18, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 1, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 11, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2018
@gundalow gundalow merged commit 86b72d1 into ansible:devel Aug 28, 2018
@gundalow
Copy link
Contributor

Thanks, merged into devel for release in Ansible 2.7

@sdodsley sdodsley deleted the purefa_facts_qos branch September 2, 2018 16:29
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sile16 sile16 sile16 approved these changes

@gundalow gundalow gundalow approved these changes

@wobbly2732 wobbly2732 wobbly2732 approved these changes

@sbelenitsky sbelenitsky sbelenitsky approved these changes

@genegr genegr genegr approved these changes

@aReT1903 aReT1903 aReT1903 approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sdodsley @gundalow @sile16 @wobbly2732 @sbelenitsky @genegr @aReT1903 @ansibot @jborean93