Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the vultr module prefixes from vr_ to vultr_ #42942

Closed
5 tasks done
resmo opened this issue Jul 18, 2018 · 3 comments · Fixed by #43994
Closed
5 tasks done

Rename the vultr module prefixes from vr_ to vultr_ #42942

resmo opened this issue Jul 18, 2018 · 3 comments · Fixed by #43994
Assignees
@resmo
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vultr Vultr community

Comments

@resmo
Copy link
Contributor

resmo commented Jul 18, 2018 •
edited

SUMMARY

as pointed out by @dagwieers the prefix for vultr modules vr_ is not recognizable and as vultr is a relatively short name, it would probably help in the future to free the vr_ "namespace" for others (with a much longer name". That is why we should rename all vultr modules prefixes to vultr_

Todos:

  • Check BOTMETA
  • Modules
  • Docs in modules
  • Upgrade notes
  • Tests
ISSUE TYPE
  • Feature Idea
COMPONENT NAME

vultr

ANSIBLE VERSION
2.7
@resmo resmo self-assigned this Jul 18, 2018
@dagwieers
Copy link
Contributor

@resmo Thanks for this !

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 18, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2018

cc @Spredzy
click here for bot help

@ansibot ansibot added the cloud label Jul 19, 2018
@resmo resmo mentioned this issue Aug 11, 2018
Merged
@resmo
Copy link
Contributor Author

resmo commented Aug 11, 2018

resolved_by_pr #43994

@dagwieers dagwieers added the vultr Vultr community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@resmo resmo

Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vultr: rename prefix vr_to vultr_
4 participants
@resmo @dagwieers @samdoran @ansibot