NetApp: return lun info for na_ontap_lun_map module

[njferrant]

SUMMARY

Added return values for the na_ontap_lun_map module. Module will now return useful information about the mapped LUN such as the NAA ID, size, OS type, and state. Also updates documentation.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

na_ontap_lun_map.py

ANSIBLE VERSION

ansible 2.6.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/etc/ansible/library']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Aug  2 2016, 04:20:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]

ADDITIONAL INFORMATION

Output before:

changed: [localhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "hostname": "netapp01",
            "https": "True",
            "initiator_group_name": "esxi_hosts",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "path": "/vol/vol01/lun01",
            "state": "present",
            "username": "admin",
            "vserver": "netapp01_san"
        }
    },
}

Output after:

changed: [localhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "hostname": "netapp01",
            "https": "True",
            "initiator_group_name": "esxi_hosts",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "path": "/vol/vol01/lun01",
            "state": "present",
            "username": "admin",
            "vserver": "netapp01_san"
        }
    },
    "lun_naa_id": "600a0980383045372f5d4c5a70315474",
    "lun_node": "netapp01b",
    "lun_ostype": "vmware",
    "lun_serial": "80E7/]LZp1Tt",
    "lun_size": "2199023255552",
    "lun_state": "online"
}

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_lun_map.py:145:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_lun_map.py:145:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_lun_map.py:100:16: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_lun_map.py:100:16: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

[ansibot]

cc @amit0701 @carchi8py @hulquest @lmprice @ndswartz @schmots1
click here for bot help

[amit0701]

LGTM. Thanks for the help Nick ! shipit

[njferrant]

bot_status

[ansibot]

Components

lib/ansible/modules/storage/netapp/na_ontap_lun_map.py
support: community
maintainers: amit0701 carchi8py hulquest lmprice ndswartz schmots1

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): amit0701
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

[carchi8py]

shipit