Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wait_for.py #43002

Merged
merged 1 commit into from Jul 19, 2018
Merged

Update wait_for.py #43002

merged 1 commit into from Jul 19, 2018

Conversation

andyeff
Copy link
Contributor

@andyeff andyeff commented Jul 19, 2018

This change is intended to help users know that a win_wait_for module exists and should be used for working on Windows hosts, as the documentation gives the impression that this module works on Windows - but if tried, it produces a large amount of stderr output.
+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

wait_for

ANSIBLE VERSION
ADDITIONAL INFORMATION

@andyeff
Update wait_for.py
dad243e 
<!--- Your description here -->
This change is intended to help users know that a win_wait_for module exists and should be used for working on Windows hosts, as the documentation gives the impression that this module works on Windows - but if tried, it produces a large amount of stderr output.
+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2018

cc @AnderEnder @gregswift @jarv @jhoekx
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 19, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Jul 19, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 19, 2018
dagwieers
dagwieers approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I did look at making the distinction between running from controller or on remote target. But it just diffuses the main point.

@dagwieers dagwieers merged commit 26fd05c into ansible:devel Jul 19, 2018
@dagwieers
Copy link
Contributor

Thanks for doing the extra mile. Much appreciated

@andyeff andyeff deleted the patch-2 branch July 19, 2018 12:11
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andyeff @ansibot @dagwieers